[JENKINS-50268] instanceCap reached with preexisting pods #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because labels are empty
This was referenced May 22, 2018
Vlatombe
reviewed
May 25, 2018
| @@ -325,9 +325,15 @@ public int getConnectTimeout() { | |||
| * Labels for all pods started by the plugin | |||
| */ | |||
| public Map<String, String> getLabels() { | |||
| return labels == null ? Collections.emptyMap() : labels; | |||
| return labels == null || labels.isEmpty() ? DEFAULT_POD_LABELS : labels; | |||
There was a problem hiding this comment.
Given the current value of DEFAULT_POD_LABELS, the problem would be the same if you have several Jenkins instances running in the same namespace.
Maybe the DEFAULT_POD_LABELS should contain a reference to the current Jenkins instance (root url?) and cloud name in order to disambiguate.
There was a problem hiding this comment.
sounds like a good improvement :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because labels are empty
Supersedes #322 #320