[JENKINS-44285] Tool Location overwrites are not preserved #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tool location was not preserved when configuration is saved. Configuration ui is changed in jelly. NodeProperties is initialized in definition. Add NodeProperties method added.
SuppressFBWarning for SE_BAD_FIELD Tool location was not preserved when configuration is saved. Configuration ui is changed in jelly. NodeProperties is initialized in definition. Add NodeProperties method added.
NodeProperties implemented As DescribableList as in Jenkins Slave UI preserved as in Node Configuration SuppressFBWarning for SE_BAD_FIELD setNodeProperties throws IOException, throws added to methods which related.
NodeProperties implemented As DescribableList as in Jenkins Slave UI preserved as in Node Configuration SuppressFBWarning for SE_BAD_FIELD setNodeProperties throws IOException, throws added to methods which related. Comments added.
# Conflicts: # src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodTemplateUtils.java # src/test/java/org/csanchez/jenkins/plugins/kubernetes/PodTemplateUtilsTest.java
NodeProperties implemented As DescribableList as in Jenkins Slave UI preserved as in Node Configuration SuppressFBWarning for SE_BAD_FIELD setNodeProperties throws IOException, throws added to methods which related. Comments added.
|
please do not close PRs, you can update them and that way we don't lose previous comments Continuation of #318 |
|
Please continue the work in #318. This is reintroducing issues that were already fixed there, like the IOException throwing |
|
Okay, i am closing this and will continue from #318 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodeProperties implemented As DescribableList as in Jenkins Slave
UI preserved as in Node Configuration
SuppressFBWarning for SE_BAD_FIELD ( still need to user, DescribableList not solved this )
setNodeProperties throws IOException, throws added to methods which related.
Comments added.
Get Lastest updates from master and merged.