Use label as pod name when not set #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use better labels in tests to identify runaway pods
Vlatombe
reviewed
Sep 4, 2018
| @@ -69,8 +69,8 @@ public void runInPod() throws Exception { | |||
| List<PodTemplate> templates = cloud.getAllTemplates(); | |||
|
|
|||
| PodTemplate template = null; | |||
| while ((template = podTemplateWithLabel("mypod", templates)) == null) { | |||
| LOGGER.log(Level.INFO, "Waiting for mypod template to be created"); | |||
| while ((template = podTemplateWithLabel("runInPod", templates)) == null) { | |||
There was a problem hiding this comment.
Could use a TestName rule to make it generic
|
Hi @carlossg , I am trying to use a custom image with amazonlinux as base image, can you please let me know if that possible. The default jnlp agent image used can be customized by adding it to the template containerTemplate(name: 'jnlp', image: 'jenkins/jnlp-slave:3.10-1-alpine', args: '${computer.jnlpmac} ${computer.name}'), I find this on documentation but stil it using alpine image. much appreciated |
|
@yrsurya you should use jenkins-user mailing list for questions |
To filter with more accuracy
|
this means instead of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use better labels in tests to identify runaway pods