[JENKINS-53422] Declarative: do not wrap steps with container statement unless default container is changed
#377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfreex
changed the title
container statement unlesscontainer statement unless default container is changed
vfreex
force-pushed
the
declarative-not-using-container-step
branch
2 times, most recently
from
aeeb027
to
b475c5f
Compare
container is changed We met a weird issue when migrating the scripted syntax to declarative with Kubernetes plugin: The `Launcher` doesn't forward `stdin`, `stdout`, or `stderr` even though they are requested to be forwarded. This breaks many plugins that use `Launcher` to start a remote process on Jenkins slaves. This happens because when Kubernetes plugin converts declarative syntax to scripted syntax, all build steps are enclosed with a `container` statement. As a result, remote commands are run via the Kubernetes exec API rather than the jnlp agent. Since running steps via Kubernetes exec API is still considered ALPHA and there are some compatibility issues to solve, I would like to make a small change to the syntax converting process: The declarative steps will not be enclosed with a `container` statement unless an alternate default container is specified by the pipeline user.
vfreex
force-pushed
the
declarative-not-using-container-step
branch
from
b475c5f
to
f188a8c
Compare
carlossg
changed the title
container statement unless default container is changedcontainer statement unless default container is changed
carlossg
approved these changes
Oct 17, 2018
Vlatombe
approved these changes
Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We met a weird issue when migrating the scripted syntax to declarative
with Kubernetes plugin: The
Launcherdoesn't forwardstdin,stdout, orstderreven though they are requested to be forwarded.This breaks many plugins that use
Launcherto start a remote process on Jenkins slaves.This happens because when Kubernetes plugin converts declarative syntax to scripted syntax,
all build steps are enclosed with a
containerstatement.As a result, remote commands are run via the Kubernetes exec API rather than
the jnlp agent.
Since running steps via Kubernetes exec API is still considered ALPHA
and there are some compatibility issues to solve,
I would like to make a small change to the syntax converting process:
The declarative steps will not be enclosed with a
containerstatement unlessan alternate default container is specified by the pipeline user.
Issue link: https://issues.jenkins-ci.org/browse/JENKINS-53422