Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System property to override default Slave Connect Timeout in seconds #432

Merged
merged 7 commits into from
Feb 26, 2019
Merged

System property to override default Slave Connect Timeout in seconds #432

merged 7 commits into from
Feb 26, 2019

Commits on Feb 18, 2019

  1. System property to override default Slave Connect Timeout in seconds

    @v1v
    v1v committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    2fe914d View commit details
    Browse the repository at this point in the history

  2. Use @before annotation to inject the system property for testing purp… 

    …oses
    @v1v
    v1v committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    4070439 View commit details
    Browse the repository at this point in the history

  3. Use Before rather the BeforeClass which was misleading in the public … 

    …static
    @v1v
    v1v committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    70b05ae View commit details
    Browse the repository at this point in the history

  4. Before doesn't affect the system properties, let's use it in the abst… 

    …ract class
    @v1v
    v1v committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    61d9d8e View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2019

  1. BeforeClass as already shown in other Test Examples: https://github.c… 

    …om/jenkinsci/distfork-plugin/blob/d44f8939daa006a7ccec3073469d9b01ac1cf427/src/test/java/hudson/plugins/distfork/DistForkCommandTest.java#L88
    @v1v
    v1v committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    0b5d7dc View commit details
    Browse the repository at this point in the history

  2. Finally it works locally: test only the changes about the connectionT… 

    …imeout and remove changes in the abstract as it's not required
    @v1v
    v1v committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    0b1a6c3 View commit details
    Browse the repository at this point in the history

  3. Avoid testing using ITs as System Properties are not tested in that m… 

    …anner
    @v1v
    v1v committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    93861ab View commit details
    Browse the repository at this point in the history