[JENKINS-56544] Don't set build result in Declarative agent blocks #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analogous to the fixes in jenkinsci/pipeline-model-definition-plugin#322 (JENKINS-56544), since this
DeclarativeAgentScripthas the same problem.Fixes issues where parallel stages with failFast would cause the build result to be aborted instead of failure in some cases. Easiest to review the whitespace-reduced diff since this just removes a try/catch and de-indents the block. Happy to re-indent to avoid touching the lines if desired.
CC @abayer