Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pod template ID inconsistency over master reboots #988

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Commits on May 25, 2021

  1. Add optional ID to the pod template step class such that it can be su…

    …pplied by dynamic groovy and then applied if present in the step execution, thus leaving functionality unchanged for existing use cases such as manually configuring pod templates in a Jenkins UI.
    fredcooke committed May 25, 2021
    Configuration menu
    Copy the full SHA
    ff4ce52 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b8ba0e0 View commit details
    Browse the repository at this point in the history
  3. No point checking for null, the constructor handles the null the same…

    … as the default constructor which just passes null directly into this constructor anyway. So if there's a value we get what we want, and if there's not, we still get what we want. Simpler is better.
    fredcooke committed May 25, 2021
    Configuration menu
    Copy the full SHA
    3f3178e View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2021

  1. Expand static imports out so the api usage footprint is visible in di…

    …ffs and locally used methods can always be found explicitly by name.
    fredcooke committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    6dacdf5 View commit details
    Browse the repository at this point in the history
  2. NUKE this commit before final merge, obviously. Hoping this will allo…

    …w a faster CI build on the PR as the full suite is massive.
    fredcooke committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    0003b17 View commit details
    Browse the repository at this point in the history
  3. First cut of a test that I hope fails - for the right reason. Not 100…

    … percent confident in that, but can't seem to run it locally, seems like a precondition is for a legit kube env to be available for this particular test. That's both good and bad as it's more realistic but I don't currently have that available myself.
    fredcooke committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    a7abe45 View commit details
    Browse the repository at this point in the history
  4. Replace the expected message with one that is actually output to get …

    …it into the next part of the same test. The message wasn't important and I've clearly misconfigured it somehow.
    fredcooke committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    f9e5506 View commit details
    Browse the repository at this point in the history