set maven libs according to consumers #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` [ERROR] Require upper bound dependencies error for org.slf4j:slf4j-api:1.7.29 [provided] paths to dependency are: [ERROR] +-org.kohsuke:access-modifier-checker:1.31-SNAPSHOT [ERROR] +-org.apache.maven:maven-core:3.8.1 [provided] [ERROR] +-org.apache.maven:maven-resolver-provider:3.8.1 [provided] [ERROR] +-org.slf4j:slf4j-api:1.7.29 [provided] [ERROR] and [ERROR] +-org.kohsuke:access-modifier-checker:1.31-SNAPSHOT [ERROR] +-org.apache.maven:maven-core:3.8.1 [provided] [ERROR] +-org.apache.maven.resolver:maven-resolver-impl:1.6.2 [provided] [ERROR] +-org.slf4j:slf4j-api:1.7.30 [provided]``` ``` maven `3.8.1` ships with `slf4j-api` `1.7.29` so the fact its resolver requires a newer slf4j is just daft. for now (as this is an old version of maven) just ignore slf4j. Removes org.apache.commons:commons-lang as that is not a collision
jtnord
commented
Mar 6, 2023
| @@ -74,7 +78,7 @@ | |||
| <rules> | |||
| <requireUpperBoundDeps> | |||
| <excludes combine.children="append"> | |||
| <exclude>org.apache.commons:commons-lang3</exclude> | |||
| <exclude>org.slf4j:slf4j-api</exclude> | |||
There was a problem hiding this comment.
[ERROR] Require upper bound dependencies error for org.slf4j:slf4j-api:1.7.29 [provided] paths to dependency are:
[ERROR] +-org.kohsuke:access-modifier-checker:1.31-SNAPSHOT
[ERROR] +-org.apache.maven:maven-core:3.8.1 [provided]
[ERROR] +-org.apache.maven:maven-resolver-provider:3.8.1 [provided]
[ERROR] +-org.slf4j:slf4j-api:1.7.29 [provided]
[ERROR] and
[ERROR] +-org.kohsuke:access-modifier-checker:1.31-SNAPSHOT
[ERROR] +-org.apache.maven:maven-core:3.8.1 [provided]
[ERROR] +-org.apache.maven.resolver:maven-resolver-impl:1.6.2 [provided]
[ERROR] +-org.slf4j:slf4j-api:1.7.30 [provided]```
maven 3.8.1 ships with slf4j-api 1.7.29 so the fact its resolver requires a newer slf4j is just daft.
for now (as this is an old version of maven) just ignore slf4j.
Removes org.apache.commons:commons-lang as that is not a collision
basil
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use a version of maven libs that we expect to be satisfied by consumers.
cf jenkinsci/maven-hpi-plugin#440 (comment)