-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pom.xml to deploy artifacts to Maven central #70
base: master
Are you sure you want to change the base?
Conversation
Following the Sonatype's instruction. https://central.sonatype.org/publish/publish-maven/#performing-a-release-deployment Should fix jenkinsci#22
745a871
to
ced8ce3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the last time I looked at this, https://github.com/jenkinsci/central-repository-pom was introduced. For consistency with other components in the Jenkins project, I think we should switch to that parent POM and its associated processes (including having Alex publish releases in the short term, which could be expanded to more people over time as needed).
Thanks for the swift reply! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to the POM look correct to me.
@NotMyFault Are we authorized to publish new releases of org.jvnet.mock-javamail:mock-javamail
to Maven Central? And if we are, are you interested and willing to perform the releases? If so, then I think we can move forward with this PR.
According to OSSRH-2216, only Kohsuke can cut releases to this groupId. If we want to distribute this artifact on the central repository, I could drive the effort to reach out to Kohsuke and onboard myself with release permissions including everyone with preexisting release permission of common Jenkins components, if desired. Do you want to be added to this and |
This sounds great to me!
Sure, good to have more active developers able to cut releases. |
Thank you @NotMyFault, I just created a basilcrow account. |
@NotMyFault Are we still waiting on Kohsuke for this one? |
Yes, I have emailed @kohsuke, but got no response. |
Any updates? I'd love to use 2.2. |
Hi @kohsuke, gentle ping about the OSSRH portion of this. |
Hello @basil ,
I was interested in #22 and read the discussion, but wasn't sure what the conclusion was (English is not my primary language).
So, I figured that it would be simpler to show you what is necessary.
This basically follows the Sonatype's instruction.
https://central.sonatype.org/publish/publish-maven/#performing-a-release-deployment
I already have an account on Sonatype and am publishing several artifacts.
With this modification, it should be possible for me to deploy the artifact to the Maven Central manually (no GitHub Actions needed).
You might have to vouch for me when/if they ask you, but that's pretty much everything you need to do AFAIK.
If this is not what you want, feel free to close this PR. I promise I won't be offended :)
If you have any question, please let me know.
Testing done
As this change does not include any logical change, there is no new tests.
Submitter checklist