Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pom.xml to deploy artifacts to Maven central #70

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

harawata
Copy link

Hello @basil ,

I was interested in #22 and read the discussion, but wasn't sure what the conclusion was (English is not my primary language).
So, I figured that it would be simpler to show you what is necessary.

This basically follows the Sonatype's instruction.
https://central.sonatype.org/publish/publish-maven/#performing-a-release-deployment

I already have an account on Sonatype and am publishing several artifacts.
With this modification, it should be possible for me to deploy the artifact to the Maven Central manually (no GitHub Actions needed).
You might have to vouch for me when/if they ask you, but that's pretty much everything you need to do AFAIK.

If this is not what you want, feel free to close this PR. I promise I won't be offended :)
If you have any question, please let me know.

Testing done

As this change does not include any logical change, there is no new tests.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@harawata harawata requested a review from a team as a code owner January 28, 2024 04:49
basil
basil previously requested changes Jan 28, 2024
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the last time I looked at this, https://github.com/jenkinsci/central-repository-pom was introduced. For consistency with other components in the Jenkins project, I think we should switch to that parent POM and its associated processes (including having Alex publish releases in the short term, which could be expanded to more people over time as needed).

@harawata
Copy link
Author

Thanks for the swift reply!
I have updated the PR (simply replaced the parent and added a couple of <version>s).
Please let me know if there need to be more adjustments.

pom.xml Outdated Show resolved Hide resolved
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to the POM look correct to me.

@NotMyFault Are we authorized to publish new releases of org.jvnet.mock-javamail:mock-javamail to Maven Central? And if we are, are you interested and willing to perform the releases? If so, then I think we can move forward with this PR.

@NotMyFault
Copy link
Member

Are we authorized to publish new releases of org.jvnet.mock-javamail:mock-javamail to Maven Central?

According to OSSRH-2216, only Kohsuke can cut releases to this groupId.

If we want to distribute this artifact on the central repository, I could drive the effort to reach out to Kohsuke and onboard myself with release permissions including everyone with preexisting release permission of common Jenkins components, if desired.
For the record, everyone defined in the developers block of components we publish to the central repository can cut releases.

Do you want to be added to this and io.jenkins.tools namespace too, Basil?

@basil basil dismissed their stale review March 1, 2024 19:21

stale

@basil
Copy link
Member

basil commented Mar 1, 2024

If we want to distribute this artifact on the central repository, I could drive the effort to reach out to Kohsuke and onboard myself with release permissions including everyone with preexisting release permission of common Jenkins components, if desired.

This sounds great to me!

Do you want to be added to this and io.jenkins.tools namespace too, Basil?

Sure, good to have more active developers able to cut releases.

@NotMyFault NotMyFault self-assigned this Mar 1, 2024
@NotMyFault
Copy link
Member

Sure, good to have more active developers able to cut releases.

Agreed, do you have an account on the central repository already, @basil? If not, you may need to create one and let me know your username so I can get you added.

@basil
Copy link
Member

basil commented Mar 6, 2024

Agreed, do you have an account on the central repository already, @basil? If not, you may need to create one and let me know your username so I can get you added.

Thank you @NotMyFault, I just created a basilcrow account.

@basil
Copy link
Member

basil commented Mar 25, 2024

@NotMyFault Are we still waiting on Kohsuke for this one?

@NotMyFault
Copy link
Member

@NotMyFault Are we still waiting on Kohsuke for this one?

Yes, I have emailed @kohsuke, but got no response.

@basil basil requested a review from kohsuke April 10, 2024 23:09
@oytuntez
Copy link

Any updates? I'd love to use 2.2.

@basil
Copy link
Member

basil commented Sep 23, 2024

Hi @kohsuke, gentle ping about the OSSRH portion of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants