Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unix time of the timestamp for data-order. #695

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

meeusen
Copy link
Contributor

@meeusen meeusen commented Aug 22, 2024

See #485. Use the unix time to sort the timestamp column.

Testing done

Set timestamp of all resources and sort on timestamp column. Check that they are sorted chronologically

import org.jenkins.plugins.lockableresources.LockableResourcesManager

def d = 0;
LockableResourcesManager.get().getResources().each { resource ->
  resource.setReservedTimestamp(new Date().minus(d))
  d = d + 30    
}

@meeusen meeusen requested a review from a team as a code owner August 22, 2024 07:17
Copy link
Contributor

@mPokornyETM mPokornyETM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mPokornyETM mPokornyETM added this to the Feature committed milestone Sep 1, 2024
@mPokornyETM
Copy link
Contributor

fix #485

@mPokornyETM mPokornyETM added bug ui Features that may impact UI, pages made by the plugin or external UIs (BO, legacy, etc.) labels Sep 1, 2024
@mPokornyETM mPokornyETM enabled auto-merge (squash) September 3, 2024 07:39
@mPokornyETM mPokornyETM merged commit 0e3bda4 into jenkinsci:master Sep 3, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ui Features that may impact UI, pages made by the plugin or external UIs (BO, legacy, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants