Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-74890] Extract inline JavaScript from LogParserWriter.java #135

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

yaroslavafenkin
Copy link
Contributor

@yaroslavafenkin yaroslavafenkin commented Nov 22, 2024

📝 Description

Fixes CSP violations making plugin CSP compliant.

🎯 Relevant issues

https://issues.jenkins.io/browse/JENKINS-74890

💎 Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

📜 Example code

🚦 How Has This Been Tested?

Manually tested

Before the change
After the change

🏁 Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@yaroslavafenkin yaroslavafenkin requested a review from a team as a code owner November 22, 2024 15:00
@hypery2k hypery2k added this pull request to the merge queue Nov 22, 2024
Merged via the queue into jenkinsci:develop with commit 68467ae Nov 22, 2024
21 checks passed
@basil
Copy link
Member

basil commented Nov 25, 2024

Thanks @hypery2k! Could this please be released so that we can resolve jenkinsci/acceptance-test-harness#1841?

@hypery2k
Copy link
Contributor

sorry, forgotten to release. 2.3.6 is now released: https://github.com/jenkinsci/log-parser-plugin/releases/tag/v2.3.6

@basil
Copy link
Member

basil commented Nov 25, 2024

@hypery2k I see the Git tag, but I do not see the new binary uploaded to Artifactory:

https://repo.jenkins-ci.org/artifactory/releases/org/jenkins-ci/plugins/log-parser/

@hypery2k
Copy link
Contributor

now it's there

@basil
Copy link
Member

basil commented Nov 25, 2024

Thank you! I confirmed that ATH is now passing with CSP enabled. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants