Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for branding #33

Closed
jonesbusy opened this issue Sep 5, 2023 · 4 comments · Fixed by #70
Closed

Support for branding #33

jonesbusy opened this issue Sep 5, 2023 · 4 comments · Fixed by #70
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jonesbusy
Copy link
Contributor

What feature do you want to see added?

Add branding support in addition of the already implemented header, head and footer.

Example in jenkinsci/design-library-plugin#277

CSS should be pretty straightforward to change, but need to consider the logo/svg branding

Upstream changes

jenkinsci/jenkins#8462

@jonesbusy jonesbusy added enhancement New feature or request good first issue Good for newcomers labels Sep 5, 2023
@harshhgithub
Copy link

Hey , i am not understanding this issue . Pls help ,i want to contribute

@jonesbusy
Copy link
Contributor Author

Hi,

This is only to track enhancement when upstream changes are merged and released to weekly.

In the plugin we can override the head, header and footer for nothing for the branding part (the part of the left of login form). This will be possible when jenkinsci/jenkins#8462 is merged.

Adding only a new form to insert CSS will be enough.

I suggest to check links from the original message.

Regards,

@sridamul
Copy link
Member

sridamul commented Feb 14, 2024

I have added a new text-box which fetches the url and pass it to the img-src of simple-branding.jelly file, but I couldn't test the changes cause I can't find any option to view the login page (I mean no logout option available)

Used: http://localhost:8080/jenkins/login?from=%2F

branding

@jonesbusy
Copy link
Contributor Author

You can run hpi:run and create a fake local user on the system config. Then you will be able to login/logout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants