Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branding to login screen #277

Closed
wants to merge 2 commits into from
Closed

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Sep 5, 2023

This demonstrates branding of the login/register screen made possible via jenkinsci/jenkins#8462

(I'm not by far a UI designer)

Capture d’écran 2023-09-05 à 09 27 36

Testing done

Submitter checklist

This demonstrates branding of the login/register screen made possible via jenkinsci/jenkins#8462
@jonesbusy
Copy link

What about to merge this example on the design library ?

I've got a PR to implement custom branding on the login-theme plugin : jenkinsci/login-theme-plugin#70

As far as I know there is no other public consumer of the new APIs

@Vlatombe Vlatombe marked this pull request as ready for review February 14, 2024 13:24
@Vlatombe Vlatombe requested a review from a team as a code owner February 14, 2024 13:24
@Vlatombe
Copy link
Member Author

@jonesbusy Good point, I had forgotten about this PR, updated, and now ready to be reviewed/merged.

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this belongs here, as people could install this into actual instances, there's no reason I can see to for this to exist outside an initial draft PR.

This belongs in the login-theme plugin imo

@Vlatombe Vlatombe closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants