[JENKINS-52693] - Make Build Data and ElasticSearchDao serializable #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| clientBuilder = factory; | ||
| } | ||
|
|
||
| HttpClientBuilder clientBuilder() { |
There was a problem hiding this comment.
Instances of this class need to be thread safe, so I think it would be better to override readObject() instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have returned to the external Logging stories proposed in #18. In order to reduce the complexity of that pull request, I decided to implement a new plugin which would depend on the Logstash plugin instead of bundling all code inside.
Draft of such implementation is here: https://github.com/oleg-nenashev/external-logging-logstash-plugin/tree/JENKINS-52693-plugin-skeleton (to be hosted on Jenkins CI).
This pull request aggregates changes we need in order to implement such integration
Nice 2 have:
@jglick @carlossg