-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for the Jenkins tables to divs migration #11
Conversation
The current target Jenkins version in the pom.xml supports it
Also update URLs
this is https://issues.jenkins.io/browse/JENKINS-64275 @imod are you still maintaining this / able to cut a release? the plugin is broken on > 2.263 |
@timja not actively anymore - this plugin is looking for a new maintainer https://groups.google.com/g/jenkinsci-dev/c/aCmm2MyydNA/m/_WogLPs7AgAJ |
Force-pushed to fix commit metadata (My git config somehow managed to drop my email address) |
@timja - What's the best process to move this forward? I'm not interested in becoming the maintainer of this plugin, but these changes do need to be merged and released for continued support. Could we get someone with access to merge PR #9 so that these other PRs at least have a chance at passing the checks? |
@imod happy for me to pick this up for one release? I have no interest in actually maintaining it, but i can get the tables to divs fix out and handle any regression related to it |
@timja I'm happy to do so if everything would still work, but for some reason my credentials are not valid anymore - i can't upload new artifacts and i don't have the time to figure out what to do |
all passwords were reset back in March or so, Go to https://beta.accounts.jenkins.io/ to reset it |
@timja i tried to reset the password - i did not get an email when requesting a reset (tried multiple times) |
@MarkEWaite and @olblak either of you available to take a look |
I was doing some job configuration today and noticed something that I should probably add to this, but won't have time today to look into it. But, this issue is not a breaking issue, just a bug. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for the patches!
Just waiting on the plugin maintainers to approve it, it looks? |
@gbigenios you planning to 🚢 this soon? |
@gbigenios https://www.jenkins.io/doc/developer/publishing/releasing/ |
@timja thanks for the link. I've tried lots of things out but can't get past the error below. Maybe it's windows/ssh key set up/maven config/git config. I'm not sure. I need to wait until next year for some assistance from my it-admin.
|
Basically you need to make it so that ssh git@github.com works |
I did ssh -vT git@github.com
|
Is there more output from the failed release? |
|
Did you run the ssh command from the same terminal as the release? Wondering if there’s something in your IntelliJ terminal that isn’t working right |
Hi, I've been following the release of this new version with interest. The error message relates to the ssh key used to access github.
IntelliJ should inherit the environment from the shell that spawned it. I'm not sure, but it looks like your ssh key is protected with a passphrase. In that case, it is possible that the keys are not loaded in the context where IntellJ is running. One thing you could try is to load ssh keys into the ssh-agent using a terminal window (that leads to passphrase prompt) and start IntelliJ from that same session. |
@juliohm1978 thanks for your help. It took a fair bit of trial and error but that was definitely the direction to go. I reconfigured my IntelliJ to use git bash as the terminal. Then in the IntelliJ-Terminal window I could start the ssh agent in the background: I think one of my trial-runs messed up with the Tag "1.5" so I created this build as managed-scripts-1.5.1 and the next one is 1.6-SNAPSHOT. The output of the release step is here (looks okay to me): So I'm hoping it will magically appear here at some point: https://plugins.jenkins.io/managed-scripts/#releases |
This fixes issues that occur as of Jenkins 2.264:
This PR will not successfully build on the Jenkins CI server until PR #9 is merged; PRs #7 and #10 should also be merged beforehand (after PR #9 is merged and they build successfully)