It's OK not to have classes dir. #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@reviewbybees |
jglick
approved these changes
Feb 17, 2017
|
🐝 |
|
🐜 if we don't have a classes directory can you auto-generate index.jelly from the Pom description? |
|
Ah, good point. We should at a minimum print a warning if I presume this is somehow related to jenkinsci/jenkins#2754 but @kohsuke is not giving any context. |
This also solves the problem of 'empty class directory blowing up MavenArchiver, which is why I started looking into this in the first place.
kohsuke
force-pushed
the
empty-classes-dir
branch
from
8b0c36e to
9977c9e
Compare
|
l tried to generate I'll just put |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... though rare. Previously, this would have caused 'no such directory' error during execution. With this change, now it creates an empty jar file.