Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-43950] Resolve dependencies if jenkins war file does not exist #60

Closed
wants to merge 2 commits into from

Conversation

carlossg
Copy link

@carlossg carlossg commented Apr 30, 2017

JENKINS-43950

Fail fast instead of later on

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐝 though II would prefer something documented in Javadoc

@carlossg
Copy link
Author

carlossg commented May 2, 2017

Added the javadoc

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RuntimeException was enough IMHO. Anyway, re-:bee:

@jglick
Copy link
Member

jglick commented May 25, 2017

Could you git merge master please so we can get a new test run?

@oleg-nenashev
Copy link
Member

@carlossg ping

@carlossg
Copy link
Author

rebased

…file

This is a possible regression of Maven 3.5.0
@carlossg carlossg changed the title [JENKINS-43950] Print the name of the artifact if it can't be resolved [JENKINS-43950] Resolve dependencies if jenkins war file does not exist Jul 26, 2017
@jglick
Copy link
Member

jglick commented Sep 26, 2017

This seems to be solving issues similar to #63. I am not sure what the correct approach is here. Probably deserves deeper investigation into the Maven internals.

@jglick
Copy link
Member

jglick commented Jan 30, 2018

Check whether this is still reproducible after #63.

@carlossg
Copy link
Author

Fixed with #63

@carlossg carlossg closed this Jan 31, 2018
@carlossg carlossg deleted the JENKINS-43950 branch January 31, 2018 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants