[JENKINS-24064] Replace war-for-test classifier with executable-war type #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 24, 2017
Merged
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
stephenc
approved these changes
May 24, 2017
| @@ -724,7 +724,7 @@ protected Artifact getJenkinsWarArtifact() throws MojoExecutionException { | |||
| if (jenkinsWarId!=null) | |||
| match = (a.getGroupId()+':'+a.getArtifactId()).equals(jenkinsWarId); | |||
| else | |||
| match = (a.getArtifactId().equals("jenkins-war") || a.getArtifactId().equals("hudson-war")) && a.getType().equals("war"); | |||
| match = (a.getArtifactId().equals("jenkins-war") || a.getArtifactId().equals("hudson-war")) && a.getType().equals("executable-war"); | |||
There was a problem hiding this comment.
May want to fallback to finding the old one if this newer match fails
There was a problem hiding this comment.
Yeah, probably could do that, if we wanted to allow the newer plugin to be used in older POMs.
andresrc
approved these changes
May 25, 2017
|
Note that this introduced JENKINS-45245 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-24064
Should allow us to avoid deploying two copies of
jenkins.war, while simplifying howWarExploderfinds the WAR file to use.@reviewbybees