Create dedicated Cause for MCP #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
🤔 Now I realize that keeping also the username who is using the MCP server would be important. I'll modify the PR. |
Member
moved it to draft for now |
> Medium: A null pointer returned by a method risks being dereferenced in new io.jenkins.plugins.mcp.server.extensions.DefaultMcpServer$MCPCause() [io.jenkins.plugins.mcp.server.extensions.DefaultMcpServer$MCPCause, io.jenkins.plugins.mcp.server.extensions.DefaultMcpServer$MCPCause] Dereferenced at DefaultMcpServer.java:[line 101] Known null at DefaultMcpServer.java:[line 101] NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE
olamy
added
the
enhancement
olamy
reviewed
Oct 23, 2025
| job.checkPermission(Item.BUILD); | ||
| Cause.UserIdCause userIdCause = new Cause.UserIdCause(); | ||
| CauseAction action = new CauseAction(userIdCause); | ||
| CauseAction action = new CauseAction(new MCPCause()); |
Member
There was a problem hiding this comment.
could be even more simple :)
Cause.UserIdCause userIdCause = new Cause.UserIdCause();
CauseAction action = new CauseAction(userIdCause){
@Override
public String getShortDescription() {
if (userIdCause.getUserId() != null) {
return "Triggered via MCP Server by " + userIdCause.getUserId();
}
return "Triggered by MCP Server";
}
};
Bear in mind getShortDescription is deprecated so if use by other plugins it may change (not used anymore) in the future.
topikachu
reviewed
Oct 29, 2025
| job.checkPermission(Item.BUILD); | ||
| Cause.UserIdCause userIdCause = new Cause.UserIdCause(); | ||
| CauseAction action = new CauseAction(userIdCause); | ||
| CauseAction action = new CauseAction(new MCPCause()); |
Contributor
There was a problem hiding this comment.
CauseAction accepts multiple causes.
You can add both UserId and new mcp causes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for the end user to understand that the call was trigger through this plugin's code and not some manual user intervention. And among others, it allows plugins like buildtriggerbadge to offer custom badges.
Testing done
Before this change, if you trigger the build through the MCP Server, this would show this (because the code was using "UserIdCause")
With this change
Submitter checklist