-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Acegi Security with Spring Security & upgrade Spring Framework #2
base: master
Are you sure you want to change the base?
Conversation
b01e383
to
2c798c2
Compare
Hello @wenjunxiao, @ndessart what is the status of this PR? I am very much interested in this fix. This fix is related to JEP-227 which was a breaking change introduced in Jenkins 2.266 |
2c798c2
to
1772c89
Compare
Hi @613andred, I've just rebased this PR (the pom.xml was in conflict with the main branch). |
Good Day @inakoll and @wenjunxiao I was informed that this a potential fix for https://issues.jenkins.io/browse/JENKINS-3404 Thank you very much. |
Hi, is there any one looking at this? I hope this can be merged as there is an obvious issue with the latest Jenkins. Thanks. |
Hi, I also have trouble using the latest Jenkins with Mixing plugin. Can this pull request be merged? |
I can confirm the issue as well -- we're on Jenkins 2.332 LTS and this plugin is broken:
Seems like the PR is on the right track to fix. Who's in charge of review? |
Hello everyone, thx |
I have compiled and installed this revision, but it can not work with Jenkins 2.426.1:
I found that UserDetails.getPassword() returns hashed password with jbcrypt, the expression "u.getPassword() != password" in the code will always TRUE... |
I am trying the this PR as well with 2.426, but here there's no option available in the security context. |
This pull request replace acegi security with Spring Security and remove deprecated/obsolete code.
See also: jenkinsci/jenkins#4848