Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Acegi Security with Spring Security & upgrade Spring Framework #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

inakoll
Copy link

@inakoll inakoll commented Aug 31, 2021

This pull request replace acegi security with Spring Security and remove deprecated/obsolete code.
See also: jenkinsci/jenkins#4848

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@ndessart ndessart force-pushed the dev-spring-cleaning branch from b01e383 to 2c798c2 Compare August 31, 2021 09:36
@613andred
Copy link

Hello @wenjunxiao, @ndessart what is the status of this PR? I am very much interested in this fix.

This fix is related to JEP-227 which was a breaking change introduced in Jenkins 2.266

@ndessart
Copy link

Hi @613andred,

I've just rebased this PR (the pom.xml was in conflict with the main branch).
Since I'm just a regular user of this plugin and not a maintainer (I think @wenjunxiao is the current maintainer), I'd appreciate any feedback about this PR.

@peachy-devops
Copy link

Good Day @inakoll and @wenjunxiao

I was informed that this a potential fix for https://issues.jenkins.io/browse/JENKINS-3404
Can I get a feedback when can this be merged?
I want to use this plugin on Jenkins to use both ldap and jenkins user at the same time.

Thank you very much.

@noooonee
Copy link

noooonee commented Apr 3, 2022

Hi, is there any one looking at this? I hope this can be merged as there is an obvious issue with the latest Jenkins. Thanks.

@robertschulze
Copy link

Hi, I also have trouble using the latest Jenkins with Mixing plugin. Can this pull request be merged?
Thanks,
Robert

@tavin
Copy link

tavin commented Aug 16, 2022

I can confirm the issue as well -- we're on Jenkins 2.332 LTS and this plugin is broken:

java.lang.NoClassDefFoundError: hudson/util/spring/BeanBuilder

Seems like the PR is on the right track to fix. Who's in charge of review?

@Schaerlis
Copy link

Hello everyone,
Is there still someone working on this fix?
I need a solution to run Jenkins with LDAP & jenkins own DB

thx

@Ocrosoft
Copy link

Ocrosoft commented Nov 23, 2023

I have compiled and installed this revision, but it can not work with Jenkins 2.426.1:

  1. Can not login with any private user.
  2. LDAP works, but cache not.

I found that UserDetails.getPassword() returns hashed password with jbcrypt, the expression "u.getPassword() != password" in the code will always TRUE...

@TueDissingWork
Copy link

I am trying the this PR as well with 2.426, but here there's no option available in the security context.
Any pointers on why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants