Fixes warning in system admin section + color highlighting of warning and errors #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plugin now appends "msbuild.exe" if a directory has been set as "Path to MSBuild" in plugin administration. This makes the plugin work in both cases : you can set the directory containing msbuild or the full path to msbuild.exe
These modifications highlight error and warning messages generated by MSBuild. This partialy adresses JIRA 3367.
Warning regex was some missing some messages.
|
@marshall777 Do you want to take over as maintainer of this plugin? |
|
@daniel-beck Yes, I already asked for committing rights on the jenkins mailing list |
|
@marshall777 Looks like I missed that thread. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request fixes the warning message displayed in administration when setting the "path to msbuild" to the directory containing msbuild.exe. Previously, you had to fill this field with the full path to msbuild.exe while Jenkins expects it to be the directory containing the executable.
This PR makes the plugin work when only the directory is set and also keep working if the full path to msbuild.exe is set for backward compatibility purpose.
Moreover, it also add color to the console log for warning and error messages generated by msbuild.