Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-58207] Update Waffle and JNA to work with Jenkins 2.181+ #7

Merged
merged 3 commits into from
Nov 6, 2019

Conversation

FarmGeek4Life
Copy link
Contributor

Jenkins release 2.181 updated the dependency on JNA, but does not depend on JNA-Platform. With NegotiateSSO, JNA 5.3.1 was being loaded along with JNA-Platform 4.5.1 (required by Waffle).

This pull request includes the following:

  • Update Waffle-JNA from 1.9.0 to 2.0.0
  • Directly specify the dependency on JNA and JNA-Platform, 5.3.1
  • Adds a dependency on slf4j 2.0.0-alpha0 (only because Waffle-JNA depends on it...)
  • Upgrades the parent POM reference to 3.50
  • Upgrade the minimum Jenkins version to 2.181 (because I couldn't get this update to work at all with older versions)
  • Removes a no-longer-needed version check in code.

See JENKINS-58207.

…in specifying some dependency versions

This is a fix for the JNA version mismatch that occurred when Jenkins upgraded to JNA 5.3.1, leading to exceptions
@FarmGeek4Life FarmGeek4Life merged commit 7064219 into jenkinsci:master Nov 6, 2019
@FarmGeek4Life FarmGeek4Life deleted the waffle-update branch January 12, 2021 05:02
@FarmGeek4Life FarmGeek4Life added the dependencies Dependency updates label Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependency updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant