Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary javadoc workaround #102

Merged
merged 3 commits into from
Mar 13, 2022
Merged

Remove unnecessary javadoc workaround #102

merged 3 commits into from
Mar 13, 2022

Conversation

basil
Copy link
Member

@basil basil commented Mar 13, 2022

I doubt this workaround is still needed. I guess we'll find out if the CI build passes.

@basil basil requested a review from a team as a code owner March 13, 2022 00:21
MarkEWaite
MarkEWaite approved these changes Mar 13, 2022
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved if the CI job passes. I don't see who would use the APIs from the plugin, but it is not harmful to generate the javadoc.

@basil
Copy link
Member Author

basil commented Mar 13, 2022 

2022-03-13T00:28:08.158Z] /home/jenkins/workspace/nodelabelparameter-plugin_PR-102/src/main/java/org/jvnet/jenkins/plugins/nodelabelparameter/wrapper/TriggerNextBuildWrapper.java:32: error: reference not found
[2022-03-13T00:28:08.158Z]  * @see NodeParameterValue#createBuildWrapper(AbstractBuild)

Easy enough to fix.

@basil
Copy link
Member Author

basil commented Mar 13, 2022

Build is now green.

@MarkEWaite MarkEWaite merged commit 12141c6 into jenkinsci:master Mar 13, 2022
@MarkEWaite MarkEWaite changed the title Remove unnecessary workaround Remove unnecessary javadoc workaround Apr 13, 2022
@MarkEWaite MarkEWaite added the documentation Improvements or additions to documentation label Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@basil @MarkEWaite