Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-66175 - Show nodes when the button is clicked #132

Merged
merged 2 commits into from
Jun 21, 2022
Merged

[JENKINS-66175 - Show nodes when the button is clicked #132

merged 2 commits into from
Jun 21, 2022

Conversation

RayanMoarkech
Copy link
Contributor

@RayanMoarkech RayanMoarkech commented Jun 21, 2022 •
edited by MarkEWaite
Loading

JENKINS-66175 - Show nodes when the button is clicked

Fixed missing change: label -> value

Resolves issue JENKINS-66175 and JENKINS-68620

The previous commit that broke the feature: a9c89e6

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue
    No test, but did mvn install and tested the hpi file

@RayanMoarkech RayanMoarkech requested a review from a team as a code owner June 21, 2022 20:34
@MarkEWaite MarkEWaite changed the title Jenkins 66175: Fixed missing change: label -> value [JENKINS-66175]: Fixed missing change: label -> value Jun 21, 2022
@MarkEWaite MarkEWaite added the bugfix A PR that fixes a bug - used by Release Drafter label Jun 21, 2022
@MarkEWaite MarkEWaite changed the title [JENKINS-66175]: Fixed missing change: label -> value [JENKINS-66175 - Show nodes when the button is clicked Jun 21, 2022
MarkEWaite
MarkEWaite approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed fixed by interactive testing. Thanks very much!

@MarkEWaite MarkEWaite merged commit ef060ba into jenkinsci:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
bugfix A PR that fixes a bug - used by Release Drafter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RayanMoarkech @MarkEWaite