Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated constructor #401

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

jtnord
Copy link
Member

@jtnord jtnord commented Sep 18, 2024

This builds on and requires #399 but the review of that is separate.

However the change is isolated so only the subsequent commits should be reviewd.

Testing done

mvn verify

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jtnord jtnord requested a review from a team as a code owner September 18, 2024 20:25
@jtnord jtnord added the chore label Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.18%. Comparing base (3e8cbca) to head (a83c698).
Report is 5 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #401      +/-   ##
============================================
- Coverage     76.03%   74.18%   -1.85%     
+ Complexity      259      257       -2     
============================================
  Files            15       15              
  Lines          1043     1007      -36     
  Branches        149      145       -4     
============================================
- Hits            793      747      -46     
- Misses          174      187      +13     
+ Partials         76       73       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jtnord jtnord merged commit cfe74a7 into jenkinsci:master Sep 19, 2024
19 of 20 checks passed
@jtnord jtnord deleted the remove-deprecated-ctor branch September 19, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant