Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow id token lifetime to be configurable #24

Merged
merged 5 commits into from
Nov 21, 2022
Merged

Allow id token lifetime to be configurable #24

merged 5 commits into from
Nov 21, 2022

Conversation

iwarapter
Copy link
Contributor

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

This adds configuration to allow the lifetime for the issued id_tokens to be configurable, whilst maintaining the current default to ensure backwards compatability.

@iwarapter iwarapter requested a review from a team as a code owner November 15, 2022 17:10
@jglick jglick self-assigned this Nov 18, 2022
@jglick jglick added the enhancement New feature or request label Nov 18, 2022
@jglick jglick changed the title allow id_token lifetime to be configurable Allow id token lifetime to be configurable Nov 18, 2022
jglick
jglick approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits but looks good!

src/main/resources/io/jenkins/plugins/oidc_provider/config/IdTokenConfiguration/config.jelly Outdated Show resolved Hide resolved
src/test/java/io/jenkins/plugins/oidc_provider/IdTokenCredentialsTest.java Outdated Show resolved Hide resolved
src/main/java/io/jenkins/plugins/oidc_provider/IdTokenCredentials.java Outdated Show resolved Hide resolved
src/test/java/io/jenkins/plugins/oidc_provider/IdTokenCredentialsTest.java Outdated Show resolved Hide resolved
@iwarapter
Copy link
Contributor Author

hey @jglick thanks for the review have fixed all the feedback!

jglick
jglick approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gratuitous boxing, I think.

src/main/java/io/jenkins/plugins/oidc_provider/config/IdTokenConfiguration.java Outdated Show resolved Hide resolved
src/main/java/io/jenkins/plugins/oidc_provider/config/IdTokenConfiguration.java Outdated Show resolved Hide resolved
src/main/java/io/jenkins/plugins/oidc_provider/config/IdTokenConfiguration.java Outdated Show resolved Hide resolved
src/test/java/io/jenkins/plugins/oidc_provider/ConfigurationAsCodeTest.java Outdated Show resolved Hide resolved
src/test/java/io/jenkins/plugins/oidc_provider/IdTokenCredentialsTest.java Outdated Show resolved Hide resolved
@jglick jglick merged commit 182a02f into jenkinsci:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

@fcojfernandez fcojfernandez fcojfernandez approved these changes

Assignees

@jglick jglick

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iwarapter @jglick @fcojfernandez