Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to job instance methods to check for queued or building #19

Merged
merged 1 commit into from
Nov 11, 2016
Merged

Switch to job instance methods to check for queued or building #19

merged 1 commit into from
Nov 11, 2016

Conversation

jimmidyson
Copy link
Contributor

No description provided.

scoheb
scoheb reviewed Nov 11, 2016
View reviewed changes
Copy link
Contributor

@scoheb scoheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@jimmidyson jimmidyson changed the title Switch to job instane methods to check for queued or building Switch to job instance methods to check for queued or building Nov 11, 2016
@jimmidyson
Copy link
Contributor Author

@scoheb Thanks! Fancy using the new github review stuff to sign off on the code? Switch to Files changed tab, Start review & Approve or comment, etc. Just to get used to using it really for further reviews that need a bit more feedback than this change.

scoheb
scoheb approved these changes Nov 11, 2016
View reviewed changes
Copy link
Contributor

@scoheb scoheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jimmidyson jimmidyson merged commit e1a10c1 into jenkinsci:master Nov 11, 2016
@jimmidyson
Copy link
Contributor Author

Thanks @scoheb - appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scoheb scoheb scoheb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmidyson @scoheb