Various fixes #23
Merged
Various fixes #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scoheb
suggested changes
Nov 14, 2016
| private synchronized void buildModified(Build build) { | ||
| if ((build.getStatus().getPhase().equals(NEW) || build.getStatus().getPhase().equals(RUNNING)) && | ||
| private static synchronized void buildModified(Build build) { | ||
| if ((build.getStatus().getPhase().equals(NEW) || build.getStatus().getPhase().equals(PENDING) || build.getStatus().getPhase().equals(RUNNING)) && |
There was a problem hiding this comment.
may be cleaner to only get status once...before the and use later.
| @@ -162,6 +164,10 @@ public static synchronized void buildAdded(Build build) throws IOException { | |||
| return; | |||
| } | |||
|
|
|||
| if (!build.getStatus().getPhase().equals(NEW)) { | |||
| @@ -270,6 +271,14 @@ public static void cancelOpenShiftBuild(Build build) { | |||
| .done(); | |||
| } | |||
|
|
|||
| public static void updateOpenShiftBuildToPending(Build build) { | |||
There was a problem hiding this comment.
Maybe you can create a generic function that takes the Phase to set it to...PENDING, CANCELLED, etc
scoheb
reviewed
Nov 14, 2016
| public static void cancelOpenShiftBuild(Build build) { | ||
| logger.info("cancelling build in namespace " + build.getMetadata().getNamespace() + " with name: " + build.getMetadata().getName()); | ||
| public static void updateOpenShiftBuildPhase(Build build, String phase) { | ||
| logger.info("setting build to pending in namespace " + build.getMetadata().getNamespace() + " with name: " + build.getMetadata().getName()); |
There was a problem hiding this comment.
should you be outputting the "phase" here instead of pending?
There was a problem hiding this comment.
Doh thanks! Done.
scoheb
approved these changes
Nov 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for combining into one PR - just easier...
Includes: