Refactor startup check before running any watch #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scoheb
suggested changes
Nov 16, 2016
| try { | ||
| buildAdded(b); | ||
| } catch (IOException e) { | ||
| e.printStackTrace(); |
| @@ -114,6 +116,28 @@ private void configChange() { | |||
| OpenShiftUtils.initializeOpenShiftClient(server); | |||
| this.namespace = getNamespaceOrUseDefault(namespace, getOpenShiftClient()); | |||
|
|
|||
| logger.info("Waiting for Jenkins to be started"); | |||
There was a problem hiding this comment.
I am wondering why you need to do this here? Can you not wait until all jobs are loaded? Take a look at this: http://javadoc.jenkins.io/hudson/model/listeners/ItemListener.html#onLoaded()
There was a problem hiding this comment.
Good question. TBH I'm not 100% sure that everything is in the right state when ItemListener.onLoaded is called. The current way may not be the "best" or most correct way to do it but we know it works. I've raised openshift#109 to track it & test it out once I get some time.
There was a problem hiding this comment.
I'd prefer to keep it the way it is right now & try out the better way you've suggested once time allows. Are you OK with that?
scoheb
approved these changes
Nov 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.