Fixes startup ordering, especially an issue blocking Jenkins startup (oops!) #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to remove missed events window on stopping/starting triggers
|
Can this be fixed asap? |
|
Was waiting on a review, should be in today & released later. Out of interest, how are you using this? Via the RHEL test image? It's not in the Origin Jenkins image yet AFAIK (waiting on openshift/jenkins#204 which is blocked by this). |
|
I used the jenkins-persistent image and then updated all the plugins (we need to run all the plugins with the latest version since this is required by policy) |
|
Ah OK - wonder if I can pull that release from Jenkins update site somehow. |
|
Self-merging... if anyone has time to post-merge review I can fix up anything you find. |
|
@willemvd Released 0.1.1 - will be indexed to Jenkins update centre in a few hours from experience. |
|
Great, thanks! |
gabemontero
added a commit
that referenced
this pull request
May 24, 2018
* Fixed the issue of duplicate pipeline Right now, when the buildconfig name is different then git repo name then sync plugin is not able to find buildconfig by repo name while syncing back to openshift after creating a buildconfig with strategy JenkinsPipeline, and create a new buildconfig repo name, To fix this issue, added a label of gitRepository name so it will first try to find the BuildConfig with name of jenkins job, if that is not present that is our case then it will also try to find the buildconfig having label with the name of jenkins job and then if it is not present will create a new BuildConfig #27 Declared constant variable for label key Removed NPE and added comments in the code to always know the context behind this * Updated wrong logging in #28 PR
mikenairn
pushed a commit
to mikenairn/openshift-sync-plugin
that referenced
this pull request
May 28, 2018
* Fixed the issue of duplicate pipeline Right now, when the buildconfig name is different then git repo name then sync plugin is not able to find buildconfig by repo name while syncing back to openshift after creating a buildconfig with strategy JenkinsPipeline, and create a new buildconfig repo name, To fix this issue, added a label of gitRepository name so it will first try to find the BuildConfig with name of jenkins job, if that is not present that is our case then it will also try to find the buildconfig having label with the name of jenkins job and then if it is not present will create a new BuildConfig jenkinsci#27 Declared constant variable for label key Removed NPE and added comments in the code to always know the context behind this * Updated wrong logging in jenkinsci#28 PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.