Add periodic relisting of BuildConfigs and Builds #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Self-merging without review - any post merge reviews welcome & will fix up ASAP! |
scoheb
reviewed
Nov 25, 2016
| @@ -60,6 +61,7 @@ | |||
|
|
|||
| private final String namespace; | |||
| private Watch buildsWatch; | |||
| private ScheduledFuture relister; | |||
|
|
|||
| public BuildWatcher(String namespace) { | |||
There was a problem hiding this comment.
One thing to consider is to extend BuildWatcher with either PeriodicWork or ASyncPeriodicWork. It removes having to inline the task and you might benefit from built-in housekeeping...just a thought.
There was a problem hiding this comment.
Raised openshift#111 to track this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.