Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated description of global config namespaces dialog #41

Merged
merged 1 commit into from
May 10, 2017

Conversation

sabre1041
Copy link
Contributor

Removes text describing leaving namespace field blank to synchronize all namespaces. This functionality is not implemented and can be confusing for users

Copy link
Contributor

@gabemontero gabemontero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IGTM, given what I recall from what @bparees did for explicit multiple namespaces, and what I see in the code after a quick scan.

I'm going to refrain from merging at least for now ... I'd like to hear from @bparees when he gets the chance just in case I'm missing something.

@bparees
Copy link
Contributor

bparees commented May 10, 2017

yup this looks right, my bad on not fixing it when i added multinamespace support.

@bparees bparees merged commit 74bbacd into jenkinsci:master May 10, 2017
@gabemontero
Copy link
Contributor

fyi - I've pushed these changes to openshift/jenkins-sync-plugin as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants