Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enrich SCM in freestyle jobs #292

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Enrich SCM in freestyle jobs #292

wants to merge 7 commits into from

Conversation

v1v
Copy link
Member

@v1v v1v commented Jan 6, 2022

🚧

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

What

Follow up from #175

Actions

  • Test whether it actually works
  • Test with multiple scm providers
  • Enable span attributes for the git SCM
  • Does SCMListener clashes with the pipeline scm/checkout specific implementation?

@v1v v1v added the enhancement New feature or request label Jan 6, 2022
v1v added 2 commits January 6, 2022 15:02
@v1v
Add extension otherwise it won't be loaded
2ecb382
@v1v
Verify the span chain
c046e23 
It does not work yet, somehow the span Phase: Start is lonely
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuisathaverat kuisathaverat Awaiting requested review from kuisathaverat kuisathaverat will be requested when the pull request is marked ready for review kuisathaverat is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@v1v