Improved how it checks for github collaborator access

[xocasdashdash]

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Should allow closing issueCommentTrigger not working when collaborator is part of GitHub Teams #107 The handleIssueComment handler stopped working after GH chaged required permissions to fetch collaborators #104

[xocasdashdash]

This ends up calling this endpoint:

/repos/${OWNER}/${REPO}/collaborators/${username}

So it leaves all of the decision logic back on github instead of here.

[xocasdashdash]

I think this method can be deleted as its not used anymore. I can do that with no issue

[aaronwalker]

yeah I don't see an issue with removing it.

[xocasdashdash]

Sorry to ping you @aaronjwhiteside , is there any way of speeding up getting this PR merged and a new release cut? not sure who to ping about this and it's been 2+ months since i opened it.

[aaronwalker]

@xocasdashdash sorry it's been a crazy couple of months. I will review this PR and let you know. I think the changes look pretty good though

[xocasdashdash]

@aaronwalker Updated the PR removing the dead code, let me know if there's anything else to do!

[xocasdashdash]

@aaronwalker hey, sorry to ping, do you think this can get merged now?

[aaronwalker]

@aaronwalker hey, sorry to ping, do you think this can get merged now?

Just a quick one before I merge this... Have you tested the Incrementals plugin version https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/plugins/pipeline-github/2.8-140.9440018594b6/ ?

[xocasdashdash]

I did not know this existed! Will get back to you once i've validated it!

[TueDissingWork]

UPDATE: works fine with this version: 2.8-140.9440018594b6

Was simple missing correct auth config for the repo on the GitHub app.
When using version 2.8-138.d766e30bb08b is also works. Nice!

Hey, just tried the mentioned version @aaronwalker, but to avail.
Still getting: Comment Author: USERNAME is not a collaborator, and is therefore not authorized to trigger a build., when trying to trigger the build with a comment. I am, as well, part of a team.

Job: devops/autochange-pr-flow/PR-1,
IssueComment: GHIssueComment@172b2357[body=test this please,url=https://githuburl/api/v3/repos/org/repo-name/issues/comments/.....],
Comment Author: USERNAME is not a collaborator, and is therefore not authorized to trigger a build.

[xocasdashdash]

Nice!
I haven't been able to test it myself but if @TueDissingWork has, let's get this merged! :)

[xocasdashdash]

@aaronwalker are you ok with @TueDissingWork tests?