Add support for creating pull request reviews #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/org/jenkinsci/plugins/pipeline/github/PullRequestGroovyObject.java
Show resolved
Hide resolved
|
Overall thanks for the PR! I think I might merge this into a branch and flesh out the rest of the review API.. I should have some free time coming up over the holiday season. |
Closed
|
@aaronjwhiteside What do you think about merging this now and improving it in follow-on PRs? I think it provides value as it stands now. |
|
@aaronjwhiteside Is there something I can do to help move this PR forward? |
|
This is something we would like to have upstream as well. |
|
@aaronjwhiteside What's up? Let's get this merged. This PR provides value as-is and that value could have been delivered 15 months ago and leveraged by the community. No need to wait, let's be agile. |
aaronjwhiteside
approved these changes
May 9, 2020
|
Sorry this took so long! Thanks for being patient and persistent :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't see a way to create pull request reviews within the plugin, but maybe I missed it. This PR adds support to create reviews. Although the functionality in this PR is limited, I think it should suffice for MVP and can be further improved in follow on PRs.
Feedback appreciated. Thanks!