Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for getting and setting a PRs milestone #51

Merged
merged 4 commits into from
Jan 28, 2019

Conversation

aaronjwhiteside
Copy link

Improve support for getting and setting a PRs milestone

ExtendedGitHubClient.java
ExtendedPullRequestService.java

  • expanded the UncheckedIOException love to more places.

ExtendedIssueService.java

  • added a method to set an issues milestone

ExtendedMilestone.java
ExtendedMilestoneService.java

  • added to support updatedAt and closedAt fields

MilestoneGroovyObject.java

  • wrapper over ExtendedMilestone

PullRequestGroovyObject.java

  • getMilestone() now return MilestoneGroovyObject
  • setMilestone() is now @Whitelisted
  • overloaded setMilestone to take both int and MilestoneGroovyObject
  • cleaned up some IOException uglyness

ExtendedGitHubClient.java
ExtendedPullRequestService.java
- expanded the UncheckedIOException love to more places.

ExtendedIssueService.java
- added a method to set an issues milestone

ExtendedMilestone.java
ExtendedMilestoneService.java
- added to support updatedAt and closedAt fields

MilestoneGroovyObject.java
- wrapper over ExtendedMilestone

PullRequestGroovyObject.java
- getMilestone() now return MilestoneGroovyObject
- setMilestone() is now @Whitelisted
- overloaded setMilestone to take both int and MilestoneGroovyObject
- cleaned up some IOException uglyness
@aaronjwhiteside aaronjwhiteside requested a review from v1v January 26, 2019 10:35
- fixed fingbugs errors
PullRequestGroovyObject.java
- less check IOException's
- bump github client version
@aaronjwhiteside aaronjwhiteside merged commit 0ec7c90 into master Jan 28, 2019
@aaronjwhiteside aaronjwhiteside deleted the improved-milestone-support branch January 28, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant