-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose comment and author as environment variables #65
Conversation
Is this intended for comment triggers? |
yes, it's intended for the comment triggers, I'm still working on the UTs for increasing the code coverage. |
I've tried to add some UTs but no clue how to test it out :(. Happy to get some assistance if it's required, as the only tests I've have done so far where manual to validate the env variables were created on the fly when the issue commit message matched the regex |
src/main/java/org/jenkinsci/plugins/pipeline/github/trigger/GitHubParametersAction.java
Outdated
Show resolved
Hide resolved
So I think environment variables are fine and all, but what would be really cool is exposing the comment as a global object, much like the @v1v thanks for this! If you update README.md to document this, I'll merge it soon... |
Done! I also verified, once again, that everything works as expected. @aaronjwhiteside. I think we are now good to go :) |
for some reason it doesn't work for me |
Highlights
GITHUB_COMMENT
GITHUB_COMMENT_AUTHOR
Tests
Tasks