Include line in review comment API calls #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copied [@mollstam](https://github.com/mollstam) [PR](https://github.com/Tocaboca/pipeline-github-plugin/pull/1) to fix jenkinsci#88 This change sets `line` instead of `position` when adding review comments through `pullRequest.reviewComment(...)` to not have the API call fail with an error. Seems like GitHub made a change to their API, or I assume this code at one point worked at least, there's an issue upstream about this: [jenkinsci#88](jenkinsci#88)
|
@aaronwalker can you review and merge? |
I don't have permissions to merge although @aaronjwhiteside I'd be keen to be added as a maintainer for this plugin |
@aaronjwhiteside can you? |
|
@aaronjwhiteside can you look at this? |
aaronjwhiteside
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copied @mollstam PR to fix #88
This change sets
lineinstead ofpositionwhen adding review comments throughpullRequest.reviewComment(...)to not have the API call fail with an error.Seems like GitHub made a change to their API, or I assume this code at one point worked at least, there's an issue upstream about this: jenkinsci#88