Fix invalid path concatenation when url has a segment #574
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the URL ends with a
#
symbol (e.g.,https://my-jenkins.com/job/job-name/job/branch/123/pipeline-graph/#
), the application mistakenly sends requests to a nested path, resulting in repeated requests to:These requests are triggered every 3 seconds and result 404 errors.
I was able to reproduce this issue in Safari browser, which adds
/#
in the end of the url after login redirect.Steps to Reproduce:
/tree
requests are sent topipeline-graph/pipeline-graph/tree
.How to reproduce in Safari with auth redirect:
https://my-jenkins.com/job/job-name/job/branch/123/pipeline-graph
Solution
Use
URL.pathname
instead of href to get path without query parameters and segments. I have fixed ingetTreePath
and other places.Testing done
Submitter checklist