Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential state mismatch in graph overview #590

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

mr-remington
Copy link
Contributor

@mr-remington mr-remington commented Feb 18, 2025

Fixes #327

This change fixes an issue where when a child stage completes, its status is incorrectly displayed on the parent stage in the graph overview.

This bug is particularly noticeable in the complexSmokes pipeline. While this approach seems reasonable given the available node data, it may not be the definitive solution. A second review would be helpful to confirm its correctness.

(In this before screen cap the state is that of Branch A, which is incorrect, we overwrite the state to that of topStage)
Before:
Screenshot 2025-02-17 at 7 50 36 PM

After:
Screenshot 2025-02-17 at 7 50 58 PM

Testing done

Ran this change through the tests nestedStages, skippedParallel, syntheticStages, and complexSmokes, noticed no adverse effects.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@mr-remington mr-remington requested a review from a team as a code owner February 18, 2025 04:00
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine based on testing various states using complex smokes:

  1. slow pending branch, other branches with unstable and one with error, the error is shown.
  2. slow pending branch, other one with unstable

@timja timja merged commit 11d956c into jenkinsci:main Feb 24, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants