add organization folder support #12
Conversation
| } | ||
|
|
||
| /** | ||
| * Get the current setting for whether or not to use a groovy sandbox. |
There was a problem hiding this comment.
nit: Groovy (to match method comment for setUseSandbox)
|
@samrocketman Do you mind taking the opportunity to review this when you have the chance? Much appreciated! |
|
Really useful feature, hope will be merged soon! |
|
Hello, I was moving cross country for a couple months and was severely AFK from volunteer work. I'm starting to get back into the groove of things and will take a look at this. |
There was a problem hiding this comment.
It is a bit hard to tell what has changed making this more challenging to review. If you don't mind:
Please break this up into two commits.
- Commit where you copied code from other classes unmodified.
- Commit where you update the code in the classes you copied.
It makes it a little more clear that way. If you don't want to that's fine I'll still take a look as best I can.
pom.xml
Outdated
| @@ -37,7 +37,7 @@ THE SOFTWARE. | |||
| <java.level>8</java.level> | |||
| </properties> | |||
| <artifactId>pipeline-multibranch-defaults</artifactId> | |||
| <version>2.1-SNAPSHOT</version> | |||
| <version>2.2-SNAPSHOT</version> | |||
There was a problem hiding this comment.
No need to bump the snapshot version. It will be auto-bumped upon next plugin release.
There was a problem hiding this comment.
Thanks! I’ve been away a few months while moving cross country. I am back now
There was a problem hiding this comment.
The two commits is much more clear and makes it easier to review. Thanks for taking the time to do it.
coreyjonoliver
force-pushed
the
add-organization-folder-support
branch
from
2f9efbf to
33d5028
Compare
|
@samrocketman Split my work into two commits, as suggested. |
|
@samrocketman Mind giving this a review when you get a chance? |
|
Really looking forward to this being released! Any idea of the timeline? |
|
Just a friendly bump. @samrocketman do you mind taking another look at this? |
|
@samrocketman sorry to sound like a broken record, but could you give this another review? |
|
Bump! |
|
Thanks @coreyjonoliver for updating. I'll take a look at this again and test locally. |
|
Great news! Thanks for taking the time to look it over @samrocketman. |
|
I'll be able to finish this up today. Apologies for the delay. I went on a bit of a hiatus from FOSS development because moving cross country kind of drained my motivation for a lot of things. Switching social circles and other non-visible things. I really appreciate your patience with me as a maintainer. |
|
Successfully tested. This feature has been released and should be available in the update center within about 8 hours. If you want to try it now you can download https://repo.jenkins-ci.org/releases/org/jenkins-ci/plugins/pipeline-multibranch-defaults/2.1/pipeline-multibranch-defaults-2.1.hpi |
|
Thanks @coreyjonoliver for your contribution! |
No description provided.