Add the missing forward slash to run relative url

[gbhat618]

A Run object URL in Jenkins should end with a forward slash. Pipeline stage view run object is not attaching the forward slash - Jenkins has a mechanism to automatically redirect from the non forward slash to with forward slash so it is not a visible problem to the user.

Redirection happening in Jenkins core

However as we can see it still wastes a network call.

Description	Screenshot
Notice a first request returned with 302, and then the proper request comes with 200

This issue was found via the CBCI high availability controller we noticed it was flagged for builds currently in execution (these kind of cases are deliberately caught so to fix in the upstream source).

Fixing it in here would be the correct fix, as it also reduces one network call to the server.

Testing

• fixed the automated test failures
• manual testing

Screenshots before and after

Description	Before Screenshot	After Screenshot
Hoverover the run id to see the resolved full URL
Browser inspect show the relative URL correctly fixed
Opening a run page does have redirects anymore - see single call

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[gbhat618]

(looking at the test failure -- Edit: fixed)

[gbhat618]

instead of just doing "{{this.id}}/" I have added the #if... because in the test fixtures there are blanks expected;

• pipeline-stage-view-plugin/ui/src/test/resources/view/pipeline_staged/render/expected.html

  Line 50 in 296c306

  <div class="jobName"><span class="badge"><a href="">#3</a></span></div>

• pipeline-stage-view-plugin/ui/src/test/resources/view/pipeline_staged/render/expected.html

  Line 108 in 296c306

  <div class="jobName"><span class="badge"><a href="">#2</a></span></div>

• pipeline-stage-view-plugin/ui/src/test/resources/view/pipeline_staged/render/expected.html

  Line 163 in 296c306

  <div class="jobName"><span class="badge"><a href="">#1</a></span></div>

I am not sure if it is correct or not; how the runId can be null or empty 🤔 while the run name is there..

I thought I would simply update the blank href to corresponding runIds, and also fix the fixture json files;
but then I wasn't sure if it was deliberately made like this..

[jglick]

@olamy please release, or better yet https://www.jenkins.io/doc/developer/publishing/releasing-cd/