Calling toArray on an array of a possibly different (post-hook) size …

…could lead to null elements!
jenkinsci · Sep 25, 2019 · c3bcaa8 · c3bcaa8
1 parent 0e343ec
commit c3bcaa8
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/plugins-compat-tester/src/main/java/org/jenkins/tools/test/PluginCompatTester.java b/plugins-compat-tester/src/main/java/org/jenkins/tools/test/PluginCompatTester.java
@@ -518,9 +518,10 @@ private TestExecutionResult testPluginAgainst(MavenCoordinates coreCoordinates,
             forExecutionHooks.put("config", config);
             forExecutionHooks.put("pluginDir", pluginCheckoutDir);
             pcth.runBeforeExecution(forExecutionHooks);
+            args = (List<String>)forExecutionHooks.get("args");
 
             // Execute with tests
-            runner.run(mconfig, pluginCheckoutDir, buildLogFile, ((List<String>)forExecutionHooks.get("args")).toArray(new String[args.size()]));
+            runner.run(mconfig, pluginCheckoutDir, buildLogFile, args.toArray(new String[args.size()]));
 
             return new TestExecutionResult(((PomData)forExecutionHooks.get("pomData")).getWarningMessages());
         }catch(PomExecutionException e){