Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Implementation-Build rather than Plugin-GitHash #527

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

basil
Copy link
Member

@basil basil commented Apr 18, 2023

See jenkinsci/pom#419 and jenkinsci/maven-hpi-plugin#471. In jenkinsci/pom#419 I am planning to add the default specification and default implementation entries in core and core component .jar and .war files, consistent with plugin .jar and .hpi files. In jenkinsci/pom#419 I am also planning to add the Git hash as Implementation-Build to core and core component .jar and .war files, and in jenkinsci/maven-hpi-plugin#471 I am renaming this information from Plugin-GitHash (recently added) to Implementation-Build for consistency. This PR adapts to jenkinsci/maven-hpi-plugin#471. While I am temporarily supporting Plugin-GitHash for now, I plan to rip out Plugin-GitHash shortly (in a month or so) once it's no longer used by anything (not much is using it today, just the AWS Java SDK plugin I think).

@basil basil added the internal label Apr 18, 2023
@basil basil requested a review from a team as a code owner April 18, 2023 22:49
@basil basil merged commit 76d3c83 into jenkinsci:master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants