Adjusting CLI options passed to Maven test runs #82
Conversation
| @@ -210,7 +210,6 @@ public PluginCompatReport testPlugins() | |||
| mconfig.userSettingsFile = config.getM2SettingsFile(); | |||
| // TODO REMOVE | |||
| mconfig.userProperties.put( "failIfNoTests", "false" ); | |||
| mconfig.userProperties.put( "argLine", "-XX:MaxPermSize=128m" ); | |||
There was a problem hiding this comment.
This clobbered both jenkinsci/plugin-pom#131 and the corresponding local workaround in ~/.m2/settings.xml, rendering PCT unusable with the current OpenJDK 8 on Ubuntu. Even before that, it was clobbering the default argline -Xmx768M -Djava.awt.headless=true.
Anyway I question the wisdom of blindly overriding JVM ergonomics during test runs. If there are indeed some test suites which for some reason require an outlandishly large permanent generation—and IIRC this is not even a thing in Java 8 anyway?—then they ought to be specifying that in their POMs.
| @@ -482,7 +481,7 @@ private TestExecutionResult testPluginAgainst(MavenCoordinates coreCoordinates, | |||
|
|
|||
| List<String> args = new ArrayList<String>(); | |||
| args.add("--define=maven.test.redirectTestOutputToFile=false"); | |||
| args.add("--define=concurrency=1"); | |||
| args.add("--define=forkCount=1"); | |||
There was a problem hiding this comment.
As of jenkinsci/plugin-pom#80 (parent 2.37), concurrency is deprecated and forkCount is what you want. Noticed since a local profile
<profile>
<id>faster</id>
<activation>
<activeByDefault>true</activeByDefault>
</activation>
<properties>
<forkCount>1C</forkCount>
</properties>
</profile>was no longer being properly countermanded: multiple tests were running concurrently.
Some things encountered while working on jenkinsci/branch-api-plugin#134.