Skip to content

Commit

Permalink
Define slf4jVersion unconditionally
Browse files Browse the repository at this point in the history
Add a comment that slf4jVersion is only used in the profile that doesn't
use Jenkins BOM.

Conditionally defined slf4jVersion cannot be used in plugins. Even though
${slf4jVersion} expands during "validate" goal, it fails at the "flatten"
goal.
  • Loading branch information
proski committed Dec 11, 2019
1 parent 11a1767 commit 3cdc850
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,10 @@
<spotbugs.threshold>${findbugs.threshold}</spotbugs.threshold>
<!-- Defines a SpotBugs effort. Use "Max" to maximize the scan depth -->
<spotbugs.effort>${findbugs.effort}</spotbugs.effort>


<!-- Version of slf4j. Do not use. It is only for plugins that don't use BOM, declare dependency on an slf4j artifact and produce incrementals. -->
<slf4jVersion>1.7.25</slf4jVersion>

<!-- Whether to skip tests during release phase (they are executed in the prepare phase). -->
<release.skipTests>true</release.skipTests>
<!-- By default we do not create *-tests.jar. Set to false to allow other plugins to depend on test utilities in yours, using <classifier>tests</classifier>. -->
Expand Down Expand Up @@ -797,9 +800,6 @@
<name>!use-jenkins-bom</name>
</property>
</activation>
<properties>
<slf4jVersion>1.7.25</slf4jVersion>
</properties>
<dependencyManagement>
<dependencies>
<dependency>
Expand Down

0 comments on commit 3cdc850

Please sign in to comment.