Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn mvntest failures ignored in CI #874

Closed
jglick opened this issue Dec 4, 2023 · 1 comment · Fixed by #1008 or #1016
Closed

yarn mvntest failures ignored in CI #874

jglick opened this issue Dec 4, 2023 · 1 comment · Fixed by #1008 or #1016

Comments

@jglick
Copy link
Member

jglick commented Dec 4, 2023

In jenkinsci/workflow-cps-plugin#821 I struggled to figure out how this ever passed in CI. Turns out

mvn verify -Dtest=InjectedTest -Dmaven.test.failure.ignore

prints ESLint failures but passes anyway. https://github.com/eirslett/frontend-maven-plugin#ignoring-failure does not say where test failures would be recorded. Based on inspecting sources, they are not recorded anywhere at all, so using junit is not enough. I think this mojo parameter needs to be disabled in the POM so that maven.test.failure.ignore applies only to Surefire.

@timja
Copy link
Member

timja commented Sep 23, 2024

I don't believe the implementation was correct and I didn't get a chance to review it.

Re-opening it as I've filed an alternative: #1016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants