-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for frontend integration + opt-in for Jenkins integration #1016
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds OK. Is there a quick way to determine whether a given repo contains relevant tests, like a test -d something
? Are there any other @jenkinsci plugins misconfigured? (There might be some @cloudbees plugins affected, so it would be nice to have a simple thing to search for in GitHub.)
This search brings up the plugins that could be affected: Not sure of an easy way to tell if misconfigured as you can configure it in multiple different ways. but if you look further down you'll see its been configured a different way: |
Looking through the list further I saw a few categories:
For eslint there's an example in Jenkins core using the checkstyle format: https://github.com/jenkinsci/jenkins/blob/master/package.json#L18 I suspect anything using |
I'll add an eslint example before taking this out of draft and add it to workflow-cps |
62a00c5
to
da4aa2e
Compare
README.md
Outdated
<!-- TODO when enough plugins have adopted this then remove this step --> | ||
Then set the following properties in your `pom.xml` to configure the Maven build to let Jenkins report the results: | ||
|
||
```xml | ||
<properties> | ||
<maven.test.failure.ignore>false</maven.test.failure.ignore> | ||
<testFailureIgnore>${maven.test.failure.ignore}</testFailureIgnore> | ||
</properties> | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation for the marker files missed the leading dot. They were introduced by jenkinsci#1016.
Fixes #874
Restores the ability to use Jenkins to report test failures (broken in #1008) and implements support for linting.
See also discussion in #1015 (comment) where it was decided that the restoring of the support will be opt-in to ensure that by default plugins builds will not silently fail on frontend test / lint failures.
Testing done
Tested with a local SNAPSHOT in jenkinsci/workflow-cps-plugin#935
Submitter checklist