Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc since marker files are dotfiles #1042

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

hashar
Copy link
Contributor

@hashar hashar commented Oct 21, 2024

The documentation for the marker files missed the leading dot.

They were introduced by #1016.

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

The documentation for the marker files missed the leading dot.

They were introduced by jenkinsci#1016.
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops thanks!

I assume I copy pasted and the . got dropped by a word boundary thing.

@timja timja merged commit 2c7b1b8 into jenkinsci:master Oct 21, 2024
2 checks passed
@hashar
Copy link
Contributor Author

hashar commented Oct 22, 2024

I assume I copy pasted and the . got dropped by a word boundary thing.

I guess so yes. Thank you very much for the documentation you wrote in #1016 that has let me setup and enforce ESLint for a plugin :]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants