[JENKINS-54828] - Support building plugins with java.level=11

[oleg-nenashev]

WiP version of the java.level=11 support for building plugins. So far it does not quite work.

Upstream deps/issues:

• - Minimum Java version in the manifest
  • [JENKINS-20679] Try to declare the minimum Java version in the manifest maven-hpi-plugin#75
• - Extra Enforcer Rules: fails with Java 11
  • https://issues.jenkins-ci.org/browse/JENKINS-54843
  • Add support for Java 11 and test with Maven 3.6.0 mojohaus/extra-enforcer-rules#63
• - Animal Sniffer Annotations: No annotations for Java 11 (CC @olamy )
  • https://issues.jenkins-ci.org/browse/JENKINS-54842
• - Access Modifier crashes in ASM
  • https://issues.jenkins-ci.org/browse/JENKINS-54844
  • It seems we need to update ASM again for Java 11. 7.0 is still in Beta

@jenkinsci/java11-support

[batmat]

@oleg-nenashev conflicting now #134 was merged FYI.

[alecharp]

I understand the need for 1.${java.level} but it might because confusing at some point.. I guess we have no choice but to keep it that way.

[t-8ch]

ASM 7.0 (and 7.1) have been released by now.

[jglick]

This seems to have been abandoned. Anyway has it not been superseded by other work?

[oleg-nenashev]

No, this PR is still actual. But it is stale indeed

…

On Fri, May 24, 2019 at 4:08 PM Jesse Glick ***@***.***> wrote: This seems to have been abandoned. Anyway has it not been superseded by other work? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#133?email_source=notifications&email_token=AAW4RICXKLIU7FGIOJWAY6DPW7ZGJA5CNFSM4GGD6VK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWFPF2Y#issuecomment-495645419>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAW4RIDDXWF4AM3WGJFFRYTPW7ZGJANCNFSM4GGD6VKQ> .

[jtnord]

you can not activate properties like this. It requires you run maven with mvn -Djava.level=11 as it can only look at system properties - not properties defined in the <properties> section of the XML

[oleg-nenashev]

Not a big concern for me (whatever works if it is theoretically supported)

[jtnord]

the problem is it doesn't work if you have a reactor with a mix of things - you need to move everything in one to java11 (the reactor may not be the parent and all the plugins could come from different repositories with different release cycles)

[jglick]

Seems to be abandoned.

[oleg-nenashev]

Still relevant

[jetersen]

#478 might be more relevant? 😅

[oleg-nenashev]

might be more relevant? 😅

Might be. AFAICT we still have no consensus

[timja]

Might be. AFAICT we still have no consensus

I think we can just merge #478 as soon as core drops java 8.

[jglick]

This is obsolete.